Skip to content

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Dec 20, 2024

What does this PR do?

Fixes #9948. This will prevent PRs like #9449 to cause issues later down the road.

Approach taken

  • For now, changes to the following paths will trigger the fast GPU tests on PRs -
    • src/diffusers/models/modeling_utils.py
    • src/diffusers/models/model_loading_utils.py
    • src/diffusers/models/pipeline_utils.py
    • src/diffusers/models/pipeline_loading_utils.py
  • I don't think we have to run other test jobs like xformers, compilation, flax, etc. on PRs. Just examples, pipelines, and core module-level tests should be fine. No strong opinions here.

@sayakpaul sayakpaul requested review from DN6 and hlky December 20, 2024 04:13
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 19, 2025
@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Feb 19, 2025
@sayakpaul
Copy link
Member Author

@hlky @DN6 a gentle bump.

Copy link
Contributor

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sayakpaul

@sayakpaul
Copy link
Member Author

@DN6 anything else to trigger here?

@sayakpaul sayakpaul merged commit 454f82e into main Feb 20, 2025
10 of 11 checks passed
@sayakpaul sayakpaul deleted the run-fast-gpu-tests-conditionally branch February 20, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] add fast GPU workflow to the PR CI

3 participants